search

ucgmsim / Pre-processing

Pre-processing of the GM simulations (Maintainer: Jonney)
MIT License
0 stars 0 forks source link

Bug fixes #225

Closed sungeunbae closed 1 year ago

sungeunbae commented 1 year ago

UPDATE: @joelridden @claudio525 Do you see any changes? Possibly all the code changes have been merged already..

When generating source from GCMT file, it referes to list.txt (ie. selection file) to extract the relevant events. When there is no number of realisation column (ie. the second column eg. 2r), it fails to add PublicID to ordered_rels as faults[pid] is 0

So the list comprehension with 2 for-loops is best to be unrolled. Less elegant, but it works.

joelridden commented 1 year ago

I do not see any code changes, haven't been able to keep track of all the merging. Maybe you accidentally already merged it with your other PR's? You dont need to make a PR for the merges you dont need approval over (anything that isnt into master) as master should be the only branch thats protected.

sungeunbae commented 1 year ago

Thie PR needed rebase after creating it - Once I clicked it, all code changes disappeared - I think all code changes in this branch somehow made to master already. I can just delete this PR and the branch.