search

ucgmsim / slurm_gm_workflow

Porting the GM workflow to run on new NeSI HPC (Maintainer: Jonney)
MIT License
0 stars 2 forks source link

Use the system defined max wct if the estimated wallclock exceeds it #495

Closed sungeunbae closed 1 year ago

sungeunbae commented 1 year ago

This change is probably not essential, but I had this bit added to the KISTI workflos codebass sometime. When a wallclock time is estimated, this gets compared with the system's maximum allowed wall clock time and goes with the less value.

sungeunbae commented 1 year ago

This shouldn't happen? the confine_wct_node_parameters function should correctly ensure it reduces the wall clock limit even with retries to be lower than the limit? Was this an issue before the changes were made to this function?

Yes, this change was made before you recently looked at the related issue - I felt this change is no longer required, but just wanted to check with you.

sungeunbae commented 1 year ago

I'm closing this one. I guess @joelridden 's earlier fix covers the case of concern.