search

ucgmsim / slurm_gm_workflow

Porting the GM workflow to run on new NeSI HPC (Maintainer: Jonney)
MIT License
0 stars 2 forks source link

Update auto_submit.py #504

Closed mrldupuis closed 10 months ago

mrldupuis commented 11 months ago

resolves error messages

Description

Dependencies

Checklist

sungeunbae commented 10 months ago

@claudio525 will you approve this asap?

sungeunbae commented 10 months ago

The logic of this does not make sense to me, the only way the previous result could be an error is if the sim directory did not exist which seems unlikely to ever be the case as it would need to make both the sim dir and the ch_log dir. The exist ok being True is odd too me too because it would only get into that if statement if it doesn't exist.

But that being said it won't break anything having this merged, so sure.

Oh, I was reading this on phone and thought this is something funky I experienced previously and left a comment advocating this change, but I get the different view reading in on a big screen. I find it odd too. I thought this was to handle exceptions such as the presence of a symbolic link or a file of the same name, but it doesn't seem to be a case. I think if os.path.isdir() can go.