search

ucgmsim / velocity_modelling

Next-gen velocity modeling tools
1 stars 0 forks source link

Add bounding box module #2

Closed lispandfound closed 1 month ago

lispandfound commented 1 month ago

There is currently a bounding box module in qcore, this PR moves it the velocity modelling repo.

Why do that?

Three main reasons:

  1. The bounding box is the main representation of the velocity model in the new workflow, so it makes sense for the velocity model to own the internal representation of it's domain.
  2. Because of the above, when the velocity model is being worked on in the future, there may be lots of changes and additions to the bounding box module, and having to PR these into qcore and maintaining parallel branches is annoying.
  3. Keep qcore small and focussed on things that are used across many packages at once.

Other Improvements

Alongside the bounding box module code we get:

  1. A complete test suite for the bounding box module
  2. Updated github actions for the repo
  3. Basic skeleton of the project, closing #1