ucharles / Comrade

일정 조율 웹 어플리케이션
1 stars 1 forks source link

#22 <List> → <Menu>로 변경, 캘린더 리스트 가변형으로 변경 #32

Closed yypp1226 closed 2 years ago

yypp1226 commented 2 years ago

22 반영

우려되는 점

<MenuItemLink>leftIcon 속성은 <svgIcon>만 가능 현재 캘린더별로 아이콘 설정하고 있기때문에(<Avartar>) 버그 발생가능성 있음

참고 https://github.com/marmelab/react-admin/issues/1926

ucharles commented 2 years ago

우려되는 점에 대해... 해당 이슈는 leftIcon 속성에 직접 img src를 설정하고 있고, 이것이 적용되지 않는다는 내용입니다만 저희 코드에서 leftIcon<Avatar>를 적용했을 때, 경고 혹은 버그가 발생하였나요? 버그가 발생할 가능성이 있다는 것은 어떤 것을 근거로 하고 있나요?

근거로 제시하신 이슈는 오래되었고 (2018년), 저희와는 상황이 다르기 때문에 자료로는 부족하다고 생각됩니다. 그리고 문제가 예상된다면 그에 대한 해결책도 몇 가지 제시해주시면 좋을 것 같습니다.

yypp1226 commented 2 years ago

우려되는 점에 대해... 해당 이슈는 leftIcon 속성에 직접 img src를 설정하고 있고, 이것이 적용되지 않는다는 내용입니다만 저희 코드에서 leftIcon<Avatar>를 적용했을 때, 경고 혹은 버그가 발생하였나요? 버그가 발생할 가능성이 있다는 것은 어떤 것을 근거로 하고 있나요?

근거로 제시하신 이슈는 오래되었고 (2018년), 저희와는 상황이 다르기 때문에 자료로는 부족하다고 생각됩니다. 그리고 문제가 예상된다면 그에 대한 해결책도 몇 가지 제시해주시면 좋을 것 같습니다.

bundle.js:188719 You are loading @emotion/react when it is already loaded. Running multiple instances may cause problems. This can happen if multiple versions are used, or if multiple builds of the same version are used.
./node_modules/react-timezone-select/dist/esm/index.js @ bundle.js:188719
options.factory @ bundle.js:198682
__webpack_require__ @ bundle.js:198127
fn @ bundle.js:198353
./src/calendars/pages/JoinCalendar.js @ bundle.js:1582
options.factory @ bundle.js:198682
__webpack_require__ @ bundle.js:198127
fn @ bundle.js:198353
./src/App.js @ bundle.js:44
options.factory @ bundle.js:198682
__webpack_require__ @ bundle.js:198127
fn @ bundle.js:198353
./src/index.js @ bundle.js:1843
options.factory @ bundle.js:198682
__webpack_require__ @ bundle.js:198127
(anonymous) @ bundle.js:199257
(anonymous) @ bundle.js:199259
bundle.js:134227 Warning: React does not recognize the `titleAccess` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `titleaccess` instead. If you accidentally passed it from a parent component, remove it from the DOM element.
    at div
    at http://localhost:3000/static/js/bundle.js:5248:66
    at Avatar (http://localhost:3000/static/js/bundle.js:31710:82)
    at div
    at http://localhost:3000/static/js/bundle.js:5248:66
    at ListItemIcon (http://localhost:3000/static/js/bundle.js:46031:82)
    at a
    at LinkWithRef (http://localhost:3000/static/js/bundle.js:172546:5)
    at http://localhost:3000/static/js/bundle.js:5248:66
    at ButtonBase (http://localhost:3000/static/js/bundle.js:33041:82)
    at http://localhost:3000/static/js/bundle.js:5248:66
    at MenuItem (http://localhost:3000/static/js/bundle.js:47216:83)
    at http://localhost:3000/static/js/bundle.js:5248:66
    at http://localhost:3000/static/js/bundle.js:122150:16
    at div
    at http://localhost:3000/static/js/bundle.js:5248:66
    at div
    at http://localhost:3000/static/js/bundle.js:5248:66
    at div
    at http://localhost:3000/static/js/bundle.js:5248:66
    at Transition (http://localhost:3000/static/js/bundle.js:174334:30)
    at Collapse (http://localhost:3000/static/js/bundle.js:36174:82)
    at div
    at http://localhost:3000/static/js/bundle.js:5248:66
    at Menu (http://localhost:3000/static/js/bundle.js:122574:67)
    at div
    at MyMenu (http://localhost:3000/static/js/bundle.js:2813:74)
    at div
    at div
    at http://localhost:3000/static/js/bundle.js:5248:66
    at Paper (http://localhost:3000/static/js/bundle.js:48973:82)
    at http://localhost:3000/static/js/bundle.js:5248:66
    at div
    at http://localhost:3000/static/js/bundle.js:5248:66
    at Drawer (http://localhost:3000/static/js/bundle.js:38448:83)
    at http://localhost:3000/static/js/bundle.js:5248:66
    at Sidebar (http://localhost:3000/static/js/bundle.js:122458:15)
    at main
    at div
    at div
    at http://localhost:3000/static/js/bundle.js:5248:66
    at Layout (http://localhost:3000/static/js/bundle.js:122751:13)
    at MyLayout
    at div
    at Routes (http://localhost:3000/static/js/bundle.js:173701:5)
    at CoreAdminRouter (http://localhost:3000/static/js/bundle.js:114499:11)
    at Routes (http://localhost:3000/static/js/bundle.js:173701:5)
    at CoreAdminUI (http://localhost:3000/static/js/bundle.js:114564:15)
    at AdminUI
    at Router (http://localhost:3000/static/js/bundle.js:173634:15)
    at HistoryRouter (http://localhost:3000/static/js/bundle.js:112316:15)
    at TranslationProvider (http://localhost:3000/static/js/bundle.js:114289:19)
    at QueryClientProvider (http://localhost:3000/static/js/bundle.js:169191:21)
    at Provider (http://localhost:3000/static/js/bundle.js:169884:20)
    at CoreAdminContext (http://localhost:3000/static/js/bundle.js:114310:19)
    at InnerThemeProvider (http://localhost:3000/static/js/bundle.js:66153:70)
    at ThemeProvider (http://localhost:3000/static/js/bundle.js:64996:5)
    at ThemeProvider (http://localhost:3000/static/js/bundle.js:66173:5)
    at ThemeProvider (http://localhost:3000/static/js/bundle.js:123094:15)
    at AdminContext (http://localhost:3000/static/js/bundle.js:132897:12)
    at Admin (http://localhost:3000/static/js/bundle.js:132921:16)
    at App
    at AuthContextProvider (http://localhost:3000/static/js/bundle.js:3241:70)

에러 내용 올려드립니다