not finding all plots? - Githubissues

softwareuser99 commented 3 years ago

Hi there and thanks for the fix on the other vision with the trailing "/".. I've run into another issue that I am having a hard time debugging... So after installing, I am running the command:

/mnt$ plotfilter -n -t /mnt/chia-ultra -d /mnt/chia-ultra-pool These are 2 valid mountpoints in my test environment. The "chia-ultra" folder has 7 valid plots but the script only checks for 4.. Could you think of any reason? Would that suggest 3 out of the 7 plots are not valid? I'll test some more but was wondering whether you had come across something similar so far.. Thanks again for the script!

2021-08-13_15-53-23

uchiafarmer commented 3 years ago

Y'know I didn't even test for bad or invalid plots so I have no idea.

Did those same plots pass regular chia plots check?

uchiafarmer commented 3 years ago

So just an update, I figured out a way to make an invalid plot. And while running chia plots check it returned this:

2021-08-14T14:53:41.255  chia.plotting.plot_tools         : WARNING  Plot /media/uchiafarmer/testplots/plot-k32-2021-08-14-13-23-8fc4786d4214b02fffa9db5a227392e6b6090c5ae0a0485ee077312f061276b9.plot has a farmer public key that is not in the farmer's pk list.            
goodbit, failbit, badbit, eofbit: 0402

When running plotfilter it showed this:

2021-08-14 15:19:51.001  =========================
2021-08-14 15:19:51.002  INFO: Dry run in progress
2021-08-14 15:19:51.004  =========================
2021-08-14 15:19:51.005  Target directory found: /media/uchiafarmer/testplots
2021-08-14 15:19:51.007  Destination directory not found, creating new directory: /media/uchiafarmer/testplots/og-plots
2021-08-14 15:19:51.008  Dry run. Skipping.
2021-08-14 15:19:51.010  'chia-blockchain' virtual environment detected: proceeding
2021-08-14 15:19:51.253  Target directory already exists in 'chia plot' paths
2021-08-14 15:19:51.256  Scanning target directory
2021-08-14 15:19:51.257  This may take awhile, please be patient... 
goodbit, failbit, badbit, eofbit: 04020)
2021-08-14 15:19:51.258  Progress: (7/7)
2021-08-14 15:19:52.628  Scan complete
2021-08-14 15:19:52.630  Checking plots...

So it does appear that the reason why not all the plots were detected was because of invalid plots. In this case, the reason why the plots were invalid was that the key I used to make the plot doesn't exist.

I will add a feature to show the invalid plots in the terminal output as well as the csv output.

uchiafarmer commented 3 years ago

Ok, I've updated plotfilter. I added some error handling and displaying warnings. So hopefully that will show more information.

Oddly enough, even if you have a plot that you don't have a key for, chia plots check will still test it and call it valid. Seems like a bug to me...

Also, the chia plots check isn't showing which plots are invalid on my chia software, which seems like another bug.

Done what I can for now. Let me know how you get on...

uchiafarmer / chia-tools

not finding all plots? #2