search

uchicago-capp-30320 / CivicLens

Putting the public back in public commenting
https://civic-lens.org
GNU Affero General Public License v3.0
2 stars 1 forks source link

Update qa code to add a flag in a new database table and update columns #224

Closed andrewjtdunn closed 6 months ago

andrewjtdunn commented 6 months ago

As requested in 5/17 meeting

andrewjtdunn commented 6 months ago

@abejburton how should I interpret the recommit failing here? It's not immediately clear to me what I should do

abejburton commented 6 months ago

@andrew pre commit is changing the line of code that is in red to what is in green because your original code has a line that is too long. If you want that to not happen, you need to run pre-commit on your code before pushing to github. It will automatically edit the line so that it isn't too long. Then add those changes, commit, and push.

andrewjtdunn commented 6 months ago

@abejburton in this instance, I don't really think the error is reasonable -- as far as I can tell, it's saying my SQL insertion, contained in triple quotes, is an errant comment. Moreover, when I follow its recommendation and assign that text to a variable, it then flags the variable with an error. Any advice on how to handle that?

andrewjtdunn commented 6 months ago

@abejburton in this instance, I don't really think the error is reasonable -- as far as I can tell, it's saying my SQL insertion, contained in triple quotes, is an errant comment. Moreover, when I follow its recommendation and assign that text to a variable, it then flags the variable with an error. Any advice on how to handle that?

EDIT: it seems to have solved itself, I'm not sure how