search

uchicago-capp-30320 / CivicLens

Putting the public back in public commenting
https://civic-lens.org
GNU Affero General Public License v3.0
2 stars 1 forks source link

216 more test for backend #245

Closed GregoryHo88 closed 6 months ago

GregoryHo88 commented 6 months ago

Draft pull request for a test on pagination that I've constructed. This is my first test using mocking, so appreciate any feedback on whether I have implemented this correctly.

I'm aware that we have backlogged this, but just putting it here incase you want to add it to the tests that we have

andrewjtdunn commented 6 months ago

Will look more closely this afternoon or tomorrow -- initial response is that some of the checks are failing, so something has probably been changed there (?)

GregoryHo88 commented 6 months ago

Will look more closely this afternoon or tomorrow -- initial response is that some of the checks are failing, so something has probably been changed there (?)

According to pytest logs, it seems one of the nlp tests is failing. I'll check to see if our code has induced this