Fixing redirecting to esp page

xiomara0 commented 5 months ago

Describe your changes

This will close #100. I previously didn't understand Summer's original ask, which was .... when a users clicks login> clicks spanish --> the user is re-directed back to home page. Instead the user should stay on login page but the page should be translated w.o/redirecting.

What i did:

Added a function to help deal with this and update language translation button.
i also was receiving a pre-commit error because of a docstring in xss test so i updated the quotes on that to make it 3 quotes on each side

See video to see how it works.

https://github.com/uchicago-capp-30320/new-arrivals-chi/assets/114881443/acaf3f77-9267-42e1-959f-55a675bae06c

Non-obvious technical information

Checklist before requesting a review

[ X] pre-commit run --all-files (run before pushing)
[ X] pytest if applicable
[ X] Link issue
[ X] Update relevant documentation if applicable: doc strings, readme, poetry.

xiomara0 commented 5 months ago

I think we need to update the json to contain the translations, as other pages do not have an additional JavaScript function implemented in order to handle the language switch

Made the changes based on our conversation @sumslong!

now, a new issue popped up where I can't change back to the English once I'm on the Spanish version on home page. I think it has something to do with the button being on the base.html vs on the home.html. I wanted to get your input before messing around with base.html. See video below:

https://github.com/uchicago-capp-30320/new-arrivals-chi/assets/114881443/f9fa85e6-1acd-477b-80fc-bba13445c859

sumslong commented 5 months ago

already resolved in different PR

uchicago-capp-30320 / new-arrivals-chi