search

uchicago-capp-30320 / new-arrivals-chi

GNU Affero General Public License v3.0
9 stars 0 forks source link

(bug): Translations are only partially loading #297

Open gregthemitch opened 2 months ago

gregthemitch commented 2 months ago

Describe the bug

Some pages only partially translate their text with the refactored translations.

To Reproduce

Steps to reproduce the behavior: See the home page as an example. Here the text describing the New Arrivals Resource Portal still has an English translation while the rest of the page is in Spanish. The rest of the page comes in as Spanish.

Expected behavior

All of the text should come in as the correct language.

Additional context

This happens on other pages as well. I'm not sure what the pattern is that causes some of the text to be properly translated, while others aren't.

klinkoberstar commented 2 months ago

Ah! I think I misunderstood your question when you asked me last week. Yes, it's expected behavior since we haven't formally translated all the text yet. It's set to default to english when no translated text exists.

As long as the HTML code is all written with babel as opposed to the nested JSONs we should be good for now! But I'll look at it more closely before I close the ticket.

klinkoberstar commented 2 months ago

(the "pattern" is I randomly translated some parts on each page to text the functionality) 😂

klinkoberstar commented 2 months ago

@klinkoberstar to look at general.html - make sure that the line breaks aren't causing issues with the translations. Some translations not showing up even when they exist bc of line breaks