uchicago-cs / chigame

BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Create a registration deadline feature for tournament #201

Closed MikeChen012345 closed 10 months ago

MikeChen012345 commented 11 months ago

Right now, players in a tournament are assigned to brackets right after the tournament is created. However, in a realistic setting, users should be allowed to sign up for the tournament and quit before the registration deadline. It is after the deadline that the brackets are created. We need to create this registration deadline feature accordingly. This change will affect the tournaments_brackets (# 189) and join_tournament (# 190) functionalities.

MikeChen012345 commented 11 months ago

This feature would be implemented after issue #237 has been dealt with.

MikeChen012345 commented 11 months ago

Issue #237 has been dealt with in pull request #247 . Once the branch is merged, the changes on the join_tournament and tournament_bracket features can be made.

MikeChen012345 commented 10 months ago
MikeChen012345 commented 10 months ago

The related pull request is #328.

MikeChen012345 commented 10 months ago

This issue is resolved by pull request #328. @MikeChen012345, @MuyanXie, and @rqueiroz20 worked on the code. The HTML parts and the views.py were mainly created by @MikeChen012345 and @MuyanXie, and @rqueiroz20 focused on different ways to implement the registration period feature. @jb-01 helped us review the code and made sure that the code worked as expected. Thanks!

elizabethli31 commented 10 months ago

Issue Score: Excellent

Comments: Wonderful improvement from previously allowing users to join at any time.