search

uchicago-cs / chigame

BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Fix search bar so that it correctly submits #355

Closed ptlin25 closed 9 months ago

ptlin25 commented 9 months ago

Currently, the search bar is broken; when a user tries to submit a query in the search bar, the search bar does nothing. This is due to the text input field being renamed from "query" to "query-input" and then back to "query" while the javascript uses "query-input". In order to fix this bug, the html element will have the id "query-input". This also necessitates changing the user search results view and the games search results view to use "query-input".

ptlin25 commented 9 months ago

This issue fixed the search bar by changing references to the search bar's text input field from "query" to "query-input". This not only fixed the search bar but improves clarity.

majorsylvie commented 9 months ago

Issue Score: Excellent

Comments: Minor as this was a bugfix. Thank you for providing a detailed summary of the bug!