search

uchicago-cs / chigame

BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Integrate Notifications Into Game and Tournament Invites #383

Open ishiii-s opened 9 months ago

ishiii-s commented 9 months ago

This PR addresses #301 to integrate notifications into the functionality to invite users to games and tournaments

ishiii-s commented 9 months ago

Re: game vs match invitation - everything that refers to a game invitation is an invitation for a match (since a match is a specific instance of playing a game). Sorry if that was confusing Re: showing up in inbox - this code should create a Notification object (as per the Notification class in models.py) automatically after creating an invitation. For now, I'm not concerned with how that is handled by the inbox. LMK if you're still finding an issue considering that. Sorry for any confusion!

When you use game invitation, do you mean match invitation as that's what you're using in game invitation. Also, when sending the game invitation or tournament invitation in /admin, it doesn't show up in my inbox unless I manually create a notification. Should this be the case? Also, your models look correct to me, as well as the code you implemented in views.py, just want some clarification on above.

Re: game vs match invitation - everything that refers to a game invitation is an invitation for a match (since a match is a specific instance of playing a game). Sorry if that was confusing Re: showing up in inbox - this code should create a Notification object (as per the Notification class in models.py) automatically after creating an invitation. For now, I'm not concerned with how that is handled by the inbox. LMK if you're still finding an issue considering that. Sorry for any confusion!

AndrewM131 commented 9 months ago

In the event that it isn't in the inbox, then I'm okay with the current code as I can use the tournament invite and game invite. Thank you for clarifying!