search

uchicago-cs / chigame

BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Styling the Forum Vote Buttons #388

Closed giomhern closed 9 months ago

giomhern commented 9 months ago

Purpose

Fix the rather clunky looking visuals of the forum like and dislike buttons. The intended result is to have buttons that fit the theme of the machina forum.

bburgess19 commented 9 months ago

Closing comment

We added styles to the barebones like buttons, and ensured they behaved properly when toggling and switching between button clicks.

Detailed notes

We faced some issues with the voting icons not appearing for Firefox, but that was solved by using FA5 class names for those icons, i.e. fas instead of fa-solid. (credits: @majorsylvie)

We made sure the user's vote was clear by choosing to fill an icon instead of solely changing the icon's color. This helped with accessibility. (credits: @giomhern )

We added a bit of extra space around the vote counter so the button placement would shift so much with every vote. (credits: @majorsylvie)

Thank you to @joshuamonroe and @majorsylvie for reviewing, and @giomhern for spear-heading this!

majorsylvie commented 9 months ago

Issue Score: Excellent