uchicago-cs / chigame

BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Fix logic bug in removing friends #413

Open omarelkashef opened 9 months ago

omarelkashef commented 9 months ago

Currently, when a friend is removed, the corresponding friend invitation is deleted from the database but the notification assigned to that invitation is only marked as deleted and a user can retrieve it. However, it will not have an assigned "actor" because the FriendInvitation is deleted. One solution is that FriendInvitation is be treated as and is only marked as deleted and can be retrieved with the notification. Now, we only work around this and display a message that this notification is invalid.