search

uchicago-cs / chiventure

A text adventure game engine developed in UChicago's CMSC 22000 - Introduction to Software Development
40 stars 13 forks source link

Fix old kind 4 (now kind 5) implementation in actionmanagement.c #1474

Closed sglenn-uchi closed 2 years ago

sglenn-uchi commented 2 years ago

After looking at some previous examples of how CONVERSATION mode is entered in dialogue, I realized our implementation of the TALK_TO case in do_npc_action is incomplete. My goal is to correct the implementation and make the test cases pass.

sglenn-uchi commented 2 years ago

I corrected the implementation and pushed to the npc/actions_original branch.

sglenn-uchi commented 2 years ago

After a discussion with our team leader, we are proceeding with a new, more efficient plan of correcting the kinds 4-6 (now kinds 5-7) tests. Fixing the kind 5 (new name for kind 4 due to addition of another kind by action management) is now part of the attached issue, so I'm going to close this one.

https://github.com/uchicago-cs/chiventure/issues/1474