uchicago-dsi / cbd-ocean-acidification

Automates retrieval and submission of ocean acidification data for the Center for Biological Diversity
GNU General Public License v3.0
1 stars 0 forks source link

ERDDAP Data Retrieval #11

Closed trevorspreadbury closed 2 years ago

trevorspreadbury commented 2 years ago

Creating initial PR so code review can be placed in comments.

@Tupacula -- Good job moving all your code to one generalized function. You still need to implement the the comments made in last week's code review and make sure you are following the style guide. Specifically, turn erdapp_auto_retrieval into the get_data function described in last week's comment. Make those commits and push when you are done -- they will automatically update the pull request.

Note on branches: Each branch you make will correspond to a single feature, and in the future it is more useful to name the branch over the feature (a future collaborator won't understand what this branch does by its current name). Then when you start working on a new feature (Oregon submissions), create a new branch. So delete the submission template from this branch to keep them separate.