Closed nmmull closed 2 years ago
I definitely lied, the paths have to be absolute for this to work, I'm going to fix this, which might requirer a slightly larger change.
pushed a very simple script for constructing a default configuration. I'm starting to see now why we want it hard coded, I don't know how to naturally construct the absolute paths in the OCaml code in order to create a default config file on the fly. Hopefully this dumb solution is alright for now.
Nathan Mull @.***> writes:
pushed a very simple script for constructing a default configuration. I'm starting to see now why we want it hard coded, I don't know how to naturally construct the absolute paths in the OCaml code in order to create a default config file on the fly. Hopefully this dumb solution is alright for now.
Not sure if by "how to naturally construct the absolute paths" you're really talking about file paths and not high-level config file stuff. But if the former, note the (shockingly!) undocumented (oops) File.components and File.coalesce commands in Prelude:
Better than using Prelude.String.split (= Prelude.split) for the special handling of the root /.
Config file reading is done. A couple notes:
tests
directory for OUnit testing. Maybe be useful for future testing, it can be run withdune runtest
. Still have some tests to write, but feel okay about the code for review.I'm sure there's more...anyway, for review, the outline is of new stuff is: