uchicago-library / attachment-converter

Attachment Converter: tool for batch converting attachments in an email mailbox
GNU General Public License v2.0
8 stars 3 forks source link

94 scrub bad result handling #98

Closed nmmull closed 2 months ago

nmmull commented 2 months ago

I removed the uses of Result.get_ok, but replaced one case with a new possible exception HeaderRepresentationError. It is my opinion that, if this is triggered it should be critical, and it should be reported to the user that they should contact us if they ever get this error.

As a reminder, part of the motivation of this issue was to deal with a bug that triggering an uncaught exception. This came from the fact that mrmime was putting line breaks into long file names in order to maintain the recommended margin of 80 characters. Upping the allowed line length fixed this problem.