search

uchicago-library / library_website

The University of Chicago Library Website
5 stars 5 forks source link

External Video Streamfield not working #443

Open kzadrozny opened 3 years ago

kzadrozny commented 3 years ago

Bug

External Video embed streamfield produces the error Cannot find an embed for this URL. when a valid YouTube share link is pasted in the field. The bug was first found in Library News, but it seems to also error out on standard public pages too.

ADA Issue is duplicate of issue #333 Additional ADA Issue SiteImprove is catching an error with the iframe YouTube is placed in, stating the error: Inline frame without a text alternative. SiteImprove suggests we add title=" "with descriptor in the title tag.

Steps to reproduce ~~YouTube share link produces this link: https://youtu.be/r_pjbnMXM1o and the embed code looks like:~~

kzadrozny commented 3 years ago

Older Wagtail page using video embed streamfield: https://www.lib.uchicago.edu/admin/pages/3288/edit/ Currently seems to be working as expected: https://www.lib.uchicago.edu/research/teaching/tours/

kzadrozny commented 3 years ago

Looks like the update resolved the embed widget but the sizing is now very small. This documentation may be helpful to compare to our embed model: https://docs.wagtail.io/en/stable/advanced_topics/embeds.html