search

uchicago-library / library_website

The University of Chicago Library Website
5 stars 5 forks source link

Staff directory ADA issues #671

Closed bbusenius closed 1 year ago

bbusenius commented 1 year ago

LIB20230113-20. Redundant headings in people listings (Best practice)

Issue: In the people rows, the person’s name is announced multiple times in succession because of the hidden <h3> followed by the person’s name in an <h4>, which is linked to their bio. We suggest removing the hidden <h3>, and switching the <h4> to an <h3>.

Full issue description

LIB20230113-21. Placeholder images should have empty alt text (Minor)

Issue: For listings with placeholder images, we suggest just using empty alt text on the images since they’re presentational and not content.

<img alt="" height="100" src="/media/images/default-photo.2e16d0ba.fill-100x100.jpg" width="100"

Full issue description

LIB20230113-22. Visit link labeling is announced incorrectly by NVDA (Minor)

Issue: It’s possible this is an NVDA bug. The sidebar “Visit” link is announced by NVDA as "vistour locations". There does appear to be a space between “Visit” and the visually hidden , so it's unclear why the screen reader is announcing it this way. It might have something to do with the tag not being a block level element and containing no semantics. A solution that will resolve this is to use an aria-label on the link instead of text inside the visually hidden span. Full issue description