uchicago-library / library_website

The University of Chicago Library Website
5 stars 5 forks source link

729 code cleanup on mail aliases page #766

Closed bufordrat closed 3 weeks ago

bufordrat commented 1 month ago

Fixes #729.

This is a pretty substantial rewrite/refactor of the mail aliases code which re-uses a lot of the techniques/ideas of the original version, while adopting a different overall design. Some highlights:

Because of that last bullet point, this round of changes does contain one migration, which adds the setting "contact info" to the site_settings Django app.

The code can be tested running the site by navigating to whichever of these is applicable:

To preview the error message, temporarily change MAIL_ALIASES_JSON in base.py to a bad path and refresh the site.