search

uchicago-sg / caravel

A Re-Re-Refresh the UChicago Marketplace
https://marketplace.uchicago.edu
16 stars 3 forks source link

Avoid reloading keywords protobuf on each load #234

Closed fatlotus closed 8 years ago

fatlotus commented 8 years ago

It's a bit of a hack, but it seems to reduce latency to around 600ms on the home page... as well as speeding up the API. I'm going to keep poking to see if there's anything else to cut out.

Before you merge- I'm a little worried about the feature impacts of this patch. I don't think this integration is tested (because the stubs don't handle this case), and I want to make sure this works in practice. I've played with the test instance somewhat, but can you test it as well?

https://prevent-reloading-keywords-dot-caravel-code-reviews.appspot.com

georgeteo commented 8 years ago

It seems to pass my rudimentary poking.

Should I merge?

fatlotus commented 8 years ago

Bombs away!