uci-uav-forge / uavf_2024

Flight software for Student Unmanned Aerial Systems 2024 competition
MIT License
3 stars 0 forks source link

Added auto-point camera #211

Closed Dat-Bois closed 3 months ago

Dat-Bois commented 3 months ago

Summary

Auto-points camera based on altitude change. Independent FSM so will change regardless of cameras current state when crossing a certain altitude (set to 10 meters for now)

@EricPedley just want to confirm Z-axis is the altitude in meters?

Test Plan

Issues

Dat-Bois commented 3 months ago

See the comment I left, plus one more thing: Should we make get_image_down fail or return nothing immediately if the camera state is not pointed down?

If the camera is not pointed down it will point it down and its blocking so the func will return something once its pointed down. If its stuck and unable to point it down we should put in a a timeout and then return a fail so GNC can tell the ground station the camera is stuck. Alternatively we just take a picture at whatever angle the camera is at after the timeout and still try processing it.

EricPedley commented 3 months ago

See the comment I left, plus one more thing: Should we make get_image_down fail or return nothing immediately if the camera state is not pointed down?

If the camera is not pointed down it will point it down and its blocking so the func will return something once its pointed down. If its stuck and unable to point it down we should put in a a timeout and then return a fail so GNC can tell the ground station the camera is stuck. Alternatively we just take a picture at whatever angle the camera is at after the timeout and still try processing it.

Ok sounds good. I'll add the timeout in another PR