search

ucl-bug / jaxdf

A JAX-based research framework for writing differentiable numerical simulators with arbitrary discretizations
GNU Lesser General Public License v3.0
117 stars 7 forks source link

there are bug in tutorial example #114

Closed 5huanghuai closed 1 year ago

5huanghuai commented 1 year ago

Describe the bug A clear and concise description of what the bug is. the report is "ValueError: diag input must be 1d or 2d" and the picture of sound map is error with code in the 22th cell. there are lack some code (from jaxdf.operators import gradient, diag_jacobian, sum_over_dims) in the 16th cell. To Reproduce Steps to reproduce the behavior:

  1. just doing as the tutorial example url ( https://ucl-bug.github.io/jaxdf/notebooks/helmholtz_pinn/)

Expected behavior A clear and concise description of what you expected to happen. no bug Desktop (please complete the following information):

Additional context Add any other context about the problem here.

5huanghuai commented 1 year ago

2023-05-01-230658_1702x545_scrot

astanziola commented 1 year ago

Thanks for pointing it out @5huanghuai, I will look into it!

5huanghuai commented 1 year ago

Thanks for pointing it out @5huanghuai, I will look into it!

thank you very much. It's very important for me. please check it if it's a error.

astanziola commented 1 year ago

@5huanghuai I believe the code in the main branch should fix this now, but please feel free to reopen this if that's not the case.