search

ucl-bug / jwave

A JAX-based research framework for differentiable and parallelizable acoustic simulations, on CPU, GPUs and TPUs
GNU Lesser General Public License v3.0
141 stars 21 forks source link

" test_kwave_helmholtz_fd.py " #127

Closed gangwonee closed 1 year ago

gangwonee commented 1 year ago

Hi, Can I ask about some bugs here? When executing this script, it returns "plum.function.NotFoundLookupError: For function "gradient", signature Signature(jaxdf.discretization.FiniteDifferences, builtins.list) could not be resolved." It seems only "FourierSeries" is used for solving helmholtz for now.

astanziola commented 1 year ago

I think this is due to the recent update of jaxdf. I'll fix this after Christmas :) Thanks for pointing it out!

astanziola commented 1 year ago

Hopefully this is fixed by #123 , which is not upstreamed to the main branch. Feel free to reopen this issue if the problem persists!

gangwonee commented 1 year ago

Thank you! Still there is an issue with 'gradient' to the FD field like, NotFoundLookupError: For function "gradient", signature Signature(jaxdf.discretization.FiniteDifferences, builtins.list) could not be resolved. but I will look at it. Thanks

astanziola commented 1 year ago

That is odd since all tests seem to pass here on GitHub. Did you reinstall from scratch? Note that some requirements have been updated too.