ucl-exoplanets / ExoTETHyS

GNU General Public License v3.0
17 stars 3 forks source link

update to sail.py #33

Closed jeroenbouwman closed 3 weeks ago

jeroenbouwman commented 4 weeks ago

in the sail.py module (perhaps also in other modules) the following import is made:

from scipy.integrate import simps

for newer scipy version the name has changed to simpson. Could you edit the code such that the import reads:

from scipy.integrate import simpson

gmorello commented 4 weeks ago

Hi Jeroen, This should have been already solved in #32. Try pip installing the new version, and let me know if it does not work. Many thanks

jeroenbouwman commented 3 weeks ago

I updated to the 2.0.12 version from pypi. I now get the following error:

File "exotethys/sail.py", line 2005, in get_passband_intensities my_ints_integ = simpson(my_intsmy_pce[:,None]my_waves.value[:,None], my_waves.value, axis=0) TypeError: simpson() takes 1 positional argument but 2 positional arguments (and 1 keyword-only argument) were given

The correct usage is: simpson(y, *, x=None, dx=1.0, axis=-1), so I guess one needs to explicitly state x=my_waves.value in the above line.

gmorello commented 3 weeks ago

Yes, I just noted that this problem occurs with scipy version 1.14.0. ExoTETHyS 2.0.13 should work with all scipy versions. Thanks.