search

ucl-exoplanets / ExoTETHyS

GNU General Public License v3.0
17 stars 3 forks source link

dynamic MANIFEST #4

Closed steven-murray closed 4 years ago

steven-murray commented 4 years ago

As part of JOSS review:

Creating a MANIFEST dynamically in a setup.py like in the following line: https://github.com/ucl-exoplanets/ExoTETHyS/blob/6a3909a52dcea93ded6805d6220cc5247db4cae8/setup.py#L13 is to my knowledge highly uncommon practice. There are ways to dynamically include stuff in the MANIFEST file within the file specification itself.

Is there a good reason to do this?

gmorello commented 4 years ago

I have no specific reasons. What do you advise to do?

steven-murray commented 4 years ago

Sorry for the late reply! Here's a pretty detailed list of suggestions for MANIFEST.in: https://www.reddit.com/r/Python/comments/40s8qw/simplify_your_manifestin_commands/

gmorello commented 4 years ago

I modified the setup.py without creating the MANIFEST.in as it is unnecessary. Is that fine for you?

steven-murray commented 4 years ago

absolutely.