search

ucl-exoplanets / ExoTETHyS

GNU General Public License v3.0
17 stars 3 forks source link

Requirements #5

Closed steven-murray closed 4 years ago

steven-murray commented 4 years ago

Part of JOSS review:

The requirements as specified have no version specifications. It is typically helpful to have at least some minimum version specified:

https://github.com/ucl-exoplanets/ExoTETHyS/blob/6a3909a52dcea93ded6805d6220cc5247db4cae8/setup.py#L9

gmorello commented 4 years ago

The code was originally written to work with quite old python2 libraries, but it may be quite annoying to dowgrade the libraries to see the minimum versions for the code to work. Could I just state the (new) versions for which it is guaranteed in the documentation, but without setting stringent requirements?

steven-murray commented 4 years ago

I don't think you have to find the absolute minimum required versions for the packages -- you can probably set them reasonably to whatever you have installed in your current environment. They can always be downgraded over time as well.

gmorello commented 4 years ago

Done

steven-murray commented 4 years ago

This does not seem to be done to me: the install_requires keyword has been taken out of setup.py. This will break automatic installation using pip. You can read the requirements.txt into your setup.py if you wish to reduce redundancy.

gmorello commented 4 years ago

I have just re-added the install_requires