search

ucl-exoplanets / ExoTETHyS

GNU General Public License v3.0
17 stars 3 forks source link

Installation instructions #6

Closed steven-murray closed 4 years ago

steven-murray commented 4 years ago

Part of JOSS review:

As far as I know, it is generally discouraged to install python packages with python setup.py install as this will not keep track of all installed files and so is not easily uninstallable. It is better to recommend installation using pip install ..

I will note that doing the following did not work for me:

conda create -n exotethys python=3
pip install . # from top-level directory of ExoTETHyS

but that might just be my own problem. Conda-installing maptlotlib scipy astropy then trying pip install . seems to have worked fine.

You may want to mention (depending on your intended audience) that creating a fresh environment (venv or conda) is encouraged.

gmorello commented 4 years ago

It works with pip install . I do not often use environments, but I will consider it. So maybe this issue can also be closed.

steven-murray commented 4 years ago

The README does now say to use pip install ., so I consider this good enough.