search

ucl-exoplanets / ExoTETHyS

GNU General Public License v3.0
17 stars 3 forks source link

Irregular imports #8

Closed steven-murray closed 4 years ago

steven-murray commented 4 years ago

Part of JOSS review:

This is a highly irregular/discouraged way to do imports:

https://github.com/ucl-exoplanets/ExoTETHyS/blob/ec6c6e8fb9d4fcc8f22c07556db2ce30c157c44b/exotethys/_1databases.py#L6

I recommend importing modules directly into your module.

gmorello commented 4 years ago

Replaced with "import package" for all packages that were imported through ._0imports

gmorello commented 4 years ago

I checked all the import, reinstalled the code and it still works. I think this issue can be closed.

steven-murray commented 4 years ago

I think then that _0imports.py can be removed.

gmorello commented 4 years ago

Done, thanks