search

ucl-sgnl / FSPSimulator

Python Version of the UCL FSP
Apache License 2.0
3 stars 0 forks source link

remove_items_from_dict function #58

Closed CharlesPlusC closed 1 year ago

CharlesPlusC commented 1 year ago

only "Starlink", "OneWeb", "E-Space" and are not startups? How do we make this assessment and why is it hardcoded? Surely this will just get burried in the code and we wil lforget about it. Also loads of other laaunchers are not startups. Do we plan to manually add them here each time?

CharlesPlusC commented 1 year ago

The rate is not used correctly

blueriver212 commented 1 year ago

I actually dont think this is a very useful function - as if you want to remove certain operators from a simulation, you should just remove it from your starting conditions rather than specifying it within the JSON. Therefore, I have removed it.