search

ucla-oarc-mobile / casa-on-rails

CASA on Rails is UCLA's Rails implementation of the CASA specification.
https://apps.ucla.edu
Other
11 stars 8 forks source link

Update submit app #161

Closed uclanate closed 6 years ago

uclanate commented 6 years ago

@krozett can you take a quick look at this? I rearranged the submit new app workflow, and changed the validation for URL and contact name (now not required). I haven't done this yet, but I want to add conditional validation for URL || custom URL scheme || android package name. I had trouble getting the conditional stuff to work so will save that for a later update.

@ctrance can you do a round of testing on submitting an app once Keith merges into master? thanks

ctrance commented 6 years ago

Sure @uclanate , @krozett please let me know when casa staging is updated, thanks!

uclanate commented 6 years ago

@krozett quick question. what is the best way to remove those 4 files from the commit and recommit? I'm so scared of git right now I really don't want to have to blow away the OPT repo haha

uclanate commented 6 years ago

@krozett OK so it was just the most recent commit where that happened. So I need to "go back" one commit somehow, and then re-add only the correct changes. So should I do the way where you preserve the history or do the force reset thing?

uclanate commented 6 years ago

ooo or wait I got it, I'll create a new branch and then we can merge that one.