search

ucla-oarc-mobile / mwf

UCLA Mobile Web Framework
http://mwf.ucla.edu
Other
86 stars 25 forks source link

mwf.userAgent.generateCookieContent() leaks variable into global space #132

Closed Trott closed 12 years ago

Trott commented 12 years ago

mwf.userAgent.generateCookieContent() leaks variable t into global space.

I think it's pretty obvious from the code, but if you want to replicate for 100% certainty: Open a MWF powered page in a browser. Pull up the JS console. Type "t" and see that it is undefined. Now type "mwf.userAgent.generateCookieContent()" and see that it generates cookie content. Now type "t" again and see that it now has a value.

Fix and integration test for 1.3 coming shortly.

Trott commented 12 years ago

d0ca75b fixes this in 1.3. Assigning to Eric for merge into 1.2 and (eventually) DTS.