search

ucla-oarc-mobile / mwf

UCLA Mobile Web Framework
http://mwf.ucla.edu
Other
86 stars 25 forks source link

Classification override not reflected in PHP #141

Closed ghost closed 12 years ago

ghost commented 12 years ago

While testing MWF 1.3.0 beta, I noticed inconsistent results using the override library between JavaScript and PHP. When I use Firefox or Safari (desktop) to goto a page:

index.php?override=basic

JavaScripts calls inside the index.php will return the expected classification. For example:

mwf.classification.isOverride() == true
mwf.classification.isBasic() == true
mwf.classification.isStandard() == false

However, PHP calls inside index.php is not returning the expected classification. For example,

Classification::is_basic() == true
Classification::is_standard() == true
Classification::is_full() == true

As a result, the Firefox or Safari browsers are still getting the full classification of CSS and JavaScript from MWF.

Trott commented 12 years ago

Looks like a JS bug probably caused by a partial merge. (Note to self: Do tons of frequent tiny merges rather than a mega-merge once in a while.) Should have it fixed soon.

Trott commented 12 years ago

Somehow, my cherry-pick resulted in a merge. Uh, fortunately, it's all stuff we should push to the next beta or rc or whatever anyway. You should be able to pull from master or from develop and this issue will be resolved.

ghost commented 12 years ago

Thanks for the prompt response, Rich. Pull from master and verified it's working as advertised.

On 5/2/12 3:38 PM, "Trott" <reply+i-4393683-18bad08047ff25b7b51eac0fbb9151c69b1690a3-898789@reply.gith ub.com> wrote:

Somehow, my cherry-pick resulted in a merge. Uh, fortunately, it's all stuff we should push to the next beta or rc or whatever anyway. You should be able to pull from master or from develop and this issue will be resolved.

Reply to this email directly or view it on GitHub: https://github.com/ucla/mwf/issues/141#issuecomment-5474464