search

ucla-oarc-mobile / mwf

UCLA Mobile Web Framework
http://mwf.ucla.edu
Other
86 stars 25 forks source link

Fix Bug in .menu.right #96

Closed ebollens closed 12 years ago

ebollens commented 12 years ago

Text is currently overflowing against the arrows. This is a 1.3 issue, given that .menu.right doesn't even exist before 1.3.

Trott commented 12 years ago

I'm unable to reproduce this. It looks OK in /mwf/demos/entities.php in iPhone Sim and Chrome on the Mac, even after I add tons of text to cause crazy line-wrapping. Are you in a particular browser or is there some sample code to show the problem?

I would have assumed that .menu.right was done just because we could, not because anyone had an actual legitimate use case for it at this time. I would be all for just removing it if it's not actually being used. People can override the default CSS with text-align:right to their heart's content.

ebollens commented 12 years ago

The problem is with alignment. It's either overlapping with the arrow or too far to the left.

I think for the time being, we can scrap it. I added it as a proof of concept idea for 1.3 given that .center and .left are provided.

ebollens commented 12 years ago

This is done in develop.

Trott commented 12 years ago

You should remove it from the demo/entities.php too.