Closed ebollens closed 11 years ago
The commit 46a88e1 tweaks light color implementation to use hsv
whereby the hue and saturation are extracted from the base color but the value comes from a lightness percentage. Benefit to use of hsv
value attribute over computing some percentage of assigned values in rgb
is that hsv
is a cylindrical coordinate representation of color while rgb
is a cubic coordinate representation, meaning that the hsv
approach produces consistently light colors as opposed to the rgb
one (consider YIQ conversion as an example of how red, green and blue have unequal luminosity).
The core adapter takes the
$color-
variables and computes out a number of shades, such as those used for the light variant. Unfortunately, because of the percentage-based calculation, a definition like$color-branding-primary: #FFAAAA;
causes the light variant to just show up white. Need to use the color value to set the hue, not the lightness.This pertains to the changes made in #124.