search

ucla / logon

self-service identity management prototype. not always up to date viewable build:
http://ucla.github.io/logon/
BSD 3-Clause "New" or "Revised" License
1 stars 8 forks source link

--dest=<PATH> CLI option to build to <PATH>; defaults to "dist" #14

Closed bezhermoso closed 7 years ago

bezhermoso commented 7 years ago

Hi @erutan,

I haven't figured out a sustainable workflow to integrate your work from this repo into the Angular 2 code-base we are working on yet (we are using Webpack). In the meantime, we'll need a way to specify an alternate destination directory to which your Gulp build will write the compiled assets. This PR adds that ability.

Example:

gulp build --production --dest=logon will write all built files to ./logon instead of ./dist. It defaults to dist, however, so that your existing workflow will remain the same.

bezhermoso commented 7 years ago

A couple more things I had to modify:

  1. Removed duo_php and iframe-resizer

    I don't think we need these anymore.

  2. Added resolution entry for jquery

    Without it, the bower install command has to ask for user input. This doesn't play well with automation, as well as during Docker builds which we are using for the dev workflow.

  3. --no_styleguide support

    Unfortunately, sherpa doesn't seem to understand absolute paths for the output option; it always interprets it as relative to the current working directory. For now this is the only work-around I tried that works.

  4. On cleanup, only delete contents of dist, not the directory itself.

    For our build, we need to pass an alternate destination directory which is impossible to delete (a Docker volume). I think deleting just the contents of whatever the destination directory is is sufficient.

erutan commented 7 years ago

Never got an email for this despite the @mention, and I've been moving around / dealing with some hardware failure. :/

1 - duo_php was something requested by alfonso a while back, the iframe was from me playing around with alternative approaches a while back. xss constraints killed that approach (would need some js injected on duo's side).

2 - a regression from manual editing on my part? good catch.

3/4 - Sounds good.

I'll look into porting some of these back to my template.