search

uclaacm / TeachLAFrontend

🌱 The frontend for Teach LA's online IDE, designed to teach kids how to code!
https://editor.uclaacm.com
MIT License
20 stars 39 forks source link

Potential dead code in LoginForm.js #1029

Open TomBinford opened 1 year ago

TomBinford commented 1 year ago

https://github.com/uclaacm/TeachLAFrontend/blob/ef2bc4da3c78009eab274ddbf6c6ee2942b0ce86/src/components/Login/LoginForm.js#L42-L57

I don't see how the else branch could ever be taken, and why the error message references "Firebase login services" when it's just checking two strings.