search

uclaacm / TeachLAFrontend

🌱 The frontend for Teach LA's online IDE, designed to teach kids how to code!
https://editor.uclaacm.com
MIT License
20 stars 39 forks source link

Converted the Switch.js to Switch.tsx #1092

Closed tylerdtran closed 10 months ago

tylerdtran commented 10 months ago

Typescript migration performed during the TeachLA Meeting

netlify[bot] commented 10 months ago

Deploy request for sleepy-franklin-7a3e4c pending review.

Visit the deploys page to approve it

Name Link
Latest commit 6feaeeb35e9864d9b1d18196846bb258e7d9b325
mizlan commented 10 months ago

Use imperative tense in commits.

eg Fix bug not Fixed bug

mizlan commented 10 months ago

To change a pushed commit, amend it locally and then force push

mizlan commented 10 months ago

Also fix the "Converted" commit message. This one might be a little trickier.

Also, going to push changes that will run a linter on TS files, since currently that isn't happening.

mizlan commented 10 months ago

Linter stuff is pushed, please do the following:

  1. Pull and rebase the most recent changes (git pull --rebase)
  2. Install the new dependencies (npm i)
  3. Run npm lint-ts and fix any outstanding errors.