uclaacm / acmcyber.com

The home for ACM Cyber at UCLA! Website for the premier cybersecurity club at UCLA.
https://www.acmcyber.com/
9 stars 4 forks source link

initial firstboot animation #123

Closed Arc-blroth closed 5 months ago

Arc-blroth commented 8 months ago

https://github.com/uclaacm/acmcyber.com/assets/45273859/00287a7a-ed14-4046-b96e-0168f3711e69

r2dev2 commented 8 months ago

gonna try to make a simpler version of this: just have a diamond loader that runs when u land on the page and doesn't block page load.

Also gonna use svg with path offset as it seems simpler than the css shenanigans here

r2dev2 commented 8 months ago

image I can try to do the version wehre you just have an svg that uses the path prop and css animations to do a quick loading effect but at the moment I am very busy. I will see when I have time for that. Also, my change would mainly be an implementation detail so it is not needed to wait for me before improving this pr.

This pr needs to make it such that the entire page isn't blocked by the animation because that part is very annoying to users if they have to sit through an animation to see the page. In summary:

My issues

Fixes

Arc-blroth commented 5 months ago

like a quarter later i honestly think this animation isn't all that needed so closing for now