Open mattxwang opened 3 years ago
@reginawang99
Just to confirm, was the intention of the PR to move completely away from Docker?
And what could I help with here? I tested on my computer and yarn install
and yarn start
opens up the app properly.
Just to confirm, was the intention of the PR to move completely away from Docker?
And what could I help with here? I tested on my computer and
yarn install
andyarn start
opens up the app properly.
Partially, yes - let me write this down, didn't get the opportunity to do it before. I'll tag you in the issue!
Just going through my own stale PRs, bump @matthewcn56; what do you want to do about this?
This draft PR (in its current state):
create-react-app
viareact-scripts
homepage
field inpackage.json
API_URL
to read from theDEV
env var; defaults tohttps://members.uclaacm.com/app
if we're not in dev, which currently causes a CORS issue if not deployed to itnode-sass
withsass
Lato
toOpen Sans
Locally, it builds and runs; we only run into problems once we hit the backend, as this introduces CORS issues.
To merge this, I think we need to:
yarn build
passes