search

uclaacm / membership-portal

The ACM Membership Portal
Mozilla Public License 2.0
8 stars 1 forks source link

Use getPublicProfile in leaderboard API #30

Open alexanderqchen opened 5 years ago

alexanderqchen commented 5 years ago

Issue: https://github.com/uclaacm/membership-portal/issues/29

alexanderqchen commented 5 years ago

I removed the eslint rule to allow for changing function parameters. My reasoning for this was that 1. express requires you to change the properties of the parameters (i.e. req.send()) 2. limit and offset parameters are changed widely in the codebase.

Let me know if you disagree with these rule changes. I'm also open to only allowing property changes in the parameters (which can also be done with eslint).