Get events by committee

uclaacm / membership-portal

The ACM Membership Portal

Mozilla Public License 2.0

8 stars 1 forks source link

Get events by committee #32

Closed howardwang15 closed 5 years ago

howardwang15 commented 5 years ago

Finished the events getCommitteeEvents() function to send a query to the database
Added the /committee route that takes an offset, limit, and committee as query strings

nkansal96 commented 5 years ago

From an API perspective, /app/api/v1/event?committee=hack makes more sense. Also, if you are including committee as a part of the database query, it would speed it up to include a BTREE index on it.

howardwang15 commented 5 years ago

New API endpoint...also @nkansal96 my commits aren't getting past Jenkins for some reason and it has something to do with yarn I think

nkansal96 commented 5 years ago

@howardwang15 I told @alexanderqchen what the problem was. Were you two able to figure it out?

howardwang15 commented 5 years ago

@nkansal96 Yeah we just removed node_modules and upgraded nodemon

nkansal96 commented 5 years ago

Before pushing schema updates, @alexanderqchen you should take a backup of the database. You are also going to have to monitor the docker logs to ensure that the index was created and didn't cause any database errors.

nkansal96 commented 5 years ago

@howardwang15 there should be an updated yarn.lock file in that case. You should commit that. If not, double check that the event-stream package has been removed from the dependency tree. If it's still there, use yarn why to figure out the offending parent package and instead of upgrading, try removing and then re-adding.

howardwang15 commented 5 years ago

@nkansal96 yeah event-stream is gone...the commits still aren't building tho

nkansal96 commented 5 years ago

Looks like build is failing due to missing build dependencies. Modify the Jenkensfile and add the following line after line 27:

sh 'apk add -U python make gcc g++'

howardwang15 commented 5 years ago

@nkansal96 updated

nkansal96 commented 5 years ago

LGTM. The rollout for this PR should be monitored carefully though! Remember that backup @alexanderqchen.

alexanderqchen commented 5 years ago

wait @nkansal96 what backup? yikes

nkansal96 commented 5 years ago

@alexanderqchen

Before pushing schema updates, @alexanderqchen you should take a backup of the database. You are also going to have to monitor the docker logs to ensure that the index was created and didn't cause any database errors.

There is a make target to take a snapshot of the database called pg_bkup in the Makefile in the deployments directory. You can look at the command to see where it writes the file.

howardwang15 commented 5 years ago

Ok merging PR!