search

uclaacm / membership-portal

The ACM Membership Portal
Mozilla Public License 2.0
8 stars 1 forks source link

Images are broken for past evens in uclaacm/events #42

Open RogueArt opened 3 years ago

RogueArt commented 3 years ago

Here's an image of what I see when I log in:

image

I've tested this issue on my desktop connecting from Firefox 90.0 as well as Chrome 91.0 on a Windows 10 desktop. The issue seems to be with how the image is hosted. Going into HTML and getting the image URL gives me this:

image

Meaning these images are expiring after a while. However, the images that re hosted on googleusercontent do not seem to have expired and load fine in the events page.

image

mattxwang commented 3 years ago

Hey @RogueArt, thanks for filing an issue and giving us some steps to reproduce! You're totally right; this is because the membership portal sometimes relies on Facebook event photos, which aren't permalink'd and aren't backed by any sort of SLA.

This is technically within the scope of the membership portal, which is in this somewhat inactive repo instead. Over the summer, the team is revamping the API + the backing data, and hopefully we'll be able to resolve these problems.

Going to cc: @advaithg and @lumisphere902 if they want to provide more context, they're working on our membership portal ATM!