search

uclaacm / membership-portal

The ACM Membership Portal
Mozilla Public License 2.0
8 stars 1 forks source link

switch `dev.Dockerfile` to use node14 alpine, changes bcrypt version to use node 14 binary #43

Closed mattxwang closed 2 years ago

reginawang3495 commented 3 years ago

Anything I can help with here?

mattxwang commented 3 years ago

Anything I can help with here?

Oops sorry, only just got to this.

If you can get #41 to work and/or build this locally, then this PR may not be needed - it was just one idea I had to help troubleshoot some issues that other people in the dev team had.

(Broadly, I think there's something wrong with how we use npm and Docker - I think we should only install our stuff once we're in the Docker container, which is not what we do right now)

mattxwang commented 2 years ago

Pretty sure this is stale, so going to close.