search

uclaacm / membership-portal

The ACM Membership Portal
Mozilla Public License 2.0
8 stars 1 forks source link

Server docker running #44

Closed reginawang3495 closed 2 years ago

reginawang3495 commented 2 years ago

Overview

Server docker runs with these changes, but whether it runs properly is not verified image

Change Overview

2 Main Changes Made, not 100% sure which one caused this, but 98% sure it's the first one.

1. package bcrypt -> bcryptjs

https://www.npmjs.com/package/bcryptjs

Optimized bcrypt in JavaScript with zero dependencies. Compatible to the C++ bcrypt binding on node.js and also working in the browser.

Possible TODO: docker files installing bcryptjs are probably no longer necessary. E.G. this line of rebuilding bcrypt here

2. changing python installation to specify python2

Pretty sure this isn't the working change since we used python in only bcrypt, but bcryptjs doesn't use python

Node Env

Not necessarily relevant

node -v
v10.19.0

and 

nvm install v8.9.4
nvm use v8.9.4

Other

Note: Won't be available until 9/19 so someone else should probably maintain this PR

ellieyhcheng commented 2 years ago

Changed image version to not need to install various packages and run yarn install in the image itself, not on the host system. Together with the PR on the client and on the deployment repo, this should get the dev system up.