search

uclaacm / membership-portal

The ACM Membership Portal
Mozilla Public License 2.0
8 stars 1 forks source link

Replace Facebook and email login with Google Sign-In #46

Closed dtjanaka closed 2 years ago

dtjanaka commented 2 years ago

https://github.com/uclaacm/membership-portal-ui/pull/98

ellieyhcheng commented 2 years ago

Content LGTM but someone else should check for style etc.

If you want to add flow for getting new users to fill in info, you can do where it returns a state indicating new user and have the ui redirect to the info filling card if it's the "new user" state. This could be a separate branch though.

dtjanaka commented 2 years ago

If you want to add flow for getting new users to fill in info, you can do where it returns a state indicating new user and have the ui redirect to the info filling card if it's the "new user" state. This could be a separate branch though.

The flow for getting new users to fill in info is implemented with the PENDING state and registered claim in the returned JWT. On the frontend, if a new user logs in, they are redirected to fill in their major and year. Once they fill this in, their state is changed to ACTIVE.

mattxwang commented 2 years ago

How essential is my CR? To be frank, I don't really understand all the changes / how the SSO flow has been working; I can dive deeper but it would probably take a while; more than happy to do it if it's necessary though.

advaithg commented 2 years ago

Did y'all resolve the incognito issue? If so, this is good to merge to me

I'd say wait until we nuke / back the database up before this gets merged though!