uclaacm / opensource

opensource @ acm, work-in-progress
https://opensource.uclaacm.com
MIT License
11 stars 6 forks source link

Add failsafes in case Octokit api fails. Statically-stored most information in .json files. Change revalidation period for projects page. One issue with importing several variables and functions, where I had to manually import each from their respective file, instead of importing all from '../util'. #117

Closed JCamyre closed 1 year ago

JCamyre commented 2 years ago

Add failsafes in case Octokit api fails. Statically-stored most information in .json files. Change revalidation period for projects page. One issue with importing several variables and functions, where I had to manually import each from their respective file, instead of importing all from '../util'.

Fixes uclaacm/opensource#114

mattxwang commented 2 years ago

More of a note for reproducibility: could we document how the fixtures were generated somewhere? I imagine when the APIs get updated, etc. we'll need to regenerate them, and that would be done by people who probably didn't work on this initial PR.

matthewcn56 commented 2 years ago

More of a note for reproducibility: could we document how the fixtures were generated somewhere? I imagine when the APIs get updated, etc. we'll need to regenerate them, and that would be done by people who probably didn't work on this initial PR.

Sure, this can definitely be done by adding it into a README as well as into our design doc for this project! Can you add that in as well to the README @JCamyre ?

matthewcn56 commented 1 year ago

Closed as with updates to Next.js 12, revalidation should work properly