search

uclaacm / opensource

opensource @ acm, work-in-progress
https://opensource.uclaacm.com
MIT License
11 stars 6 forks source link

Update Navigation #152

Closed jainsujay02 closed 5 months ago

jainsujay02 commented 1 year ago

The open-source site was originally intended to be a stand-alone website. However, we would now like to keep it linked to ACM's main website. This naturally causes a weird navigation experience with no way to navigate back to the main ACM website from the open-source website.

To address think, I can think of two approaches:

  1. We add a back to the main site button on the home page (which is a little cringe) but acceptable for our purposes.
  2. We modify the navigation bar so that it includes links to our main website.

Ideally, you'd experiment with both of these and see which feels more intuitive from a user's perspective.

ansh-saini commented 1 year ago

Hi. I would like to work on this. Can I take this up?

I think it'd be best to modify the navbar to include a link to the main website. I can think of two ways of doing this:

  1. We can change the link of the top left logo to the main website. image
  2. Adding a 'home' link in the links section image
jainsujay02 commented 1 year ago

Hey Ansh,

Thank you for helping out! I've assigned the ticket to you. Let me know if you've any questions. Otherwise, when you're done, please request me or Arsh Malik as your reviewer.

On Sun, Oct 1, 2023 at 12:27 AM Ansh Saini @.***> wrote:

Hi. I would like to work on this. Can I take this up?

I think it'd be best to modify the navbar to include a link to the main website. I can think of two ways of doing this:

  1. We can change the link of the top left logo to the main website. [image: image] https://user-images.githubusercontent.com/32511936/271814383-cb6dce37-1b70-4191-9705-c3d9ce1a7c70.png
  2. Adding a 'home' link in the links section [image: image] https://user-images.githubusercontent.com/32511936/271814432-63816e2f-816c-40bb-94f3-9ae0d46b1135.png

— Reply to this email directly, view it on GitHub https://github.com/uclaacm/opensource/issues/152#issuecomment-1741989410, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASXEOLCFH6D2GFKPBBMCNA3X5ELPPANCNFSM6AAAAAA4ZJB7ZA . You are receiving this because you authored the thread.Message ID: @.***>

ansh-saini commented 1 year ago

Hi @jainsujay02. I mentioned two ways of solving this problem in my previous comment. Would really like to know your thoughts on which one I should implement.

jainsujay02 commented 1 year ago

Hey Ansh,

Ah my bad, I forgot to reply to that part of your message. I prefer option 2.

On Sun, Oct 1, 2023 at 10:16 PM Ansh Saini @.***> wrote:

Hi @jainsujay02 https://github.com/jainsujay02. I mentioned two ways of solving this problem in my previous comment. Would really like to know your thoughts on which one I should implement.

— Reply to this email directly, view it on GitHub https://github.com/uclaacm/opensource/issues/152#issuecomment-1742411268, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASXEOLBFNMDMKA3DBACHKNDX5JE2JANCNFSM6AAAAAA4ZJB7ZA . You are receiving this because you were mentioned.Message ID: @.***>

ArshMalik02 commented 12 months ago

I had some thoughts to add. Intuitively, I feel like we should go with option 1 i.e. the logo in the navigation bar should be consistent with the main website since we now have open source in the main website's navigation bar and it should link to the main website's landing page. Thoughts @matthewcn56 ?

ArshMalik02 commented 5 months ago

Closed with #157